REL: v1.2.2 #405
Merged
REL: v1.2.2 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklin-feingold
requested review from
chrisgorgo,
CPernet and
sappelhoff
as code owners
sappelhoff
previously approved these changes
Feb 4, 2020
effigies
reviewed
Feb 6, 2020
src/CHANGES.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| Changelog | |||
|
|
|||
| ## [Unreleased](https://github.com/bids-standard/bids-specification/tree/HEAD) | |||
| ## [v1.2.2](https://bids-specification.readthedocs.io/en/v1.2.2/) (2020-02-03) | |||
There was a problem hiding this comment.
Can you update the links for all of the other releases?
Also, can we remove the REL changelog entries from the top of each release?
There was a problem hiding this comment.
changed the RTD links - I am hesitant to link to the previous pre-RTD until #392 has been resolved so we do not have broken links in previous versions
this can be released for stable but will appear back on latest because of how the changelog is generated (for each merged PR), a separate issue could address enhancing the changelog generation
to keep track of release protocol additions I've started a ticket (#406)
2 tasks
effigies
reviewed
Feb 9, 2020
src/CHANGES.md
Outdated
| @@ -99,7 +99,7 @@ Changelog | |||
| - \[FIX] Specify marker file names for KIT data (MEG) [#62](https://github.com/bids-standard/bids-specification/pull/62) ([monkeyman192](https://github.com/monkeyman192)) | |||
| - \[FIX] Remove father-level for meg filetypes other than BTi/4D data [#19](https://github.com/bids-standard/bids-specification/pull/19) ([teonbrooks](https://github.com/teonbrooks)) | |||
|
|
|||
| ## [v1.2.0](https://github.com/bids-standard/bids-specification/tree/v1.2.0) (2019-03-04) | |||
| ## [v1.2.0](https://bids-specification.readthedocs.io/en/v1.2.0/) (2019-03-04) | |||
|
|
|||
| - REL: v1.2.0 [#161](https://github.com/bids-standard/bids-specification/pull/161) ([chrisgorgo](https://github.com/chrisgorgo)) | |||
There was a problem hiding this comment.
Suggested change
| - REL: v1.2.0 [#161](https://github.com/bids-standard/bids-specification/pull/161) ([chrisgorgo](https://github.com/chrisgorgo)) |
src/CHANGES.md
Outdated
| @@ -117,7 +117,7 @@ Changelog | |||
| - Adding formal decision-making rules [#104](https://github.com/bids-standard/bids-specification/pull/104) ([chrisgorgo](https://github.com/chrisgorgo)) | |||
| - \[MRG] number of small corrections to the specification [#98](https://github.com/bids-standard/bids-specification/pull/98) ([robertoostenveld](https://github.com/robertoostenveld)) | |||
|
|
|||
| ## [v1.1.2](https://github.com/bids-standard/bids-specification/tree/v1.1.2) (2019-01-10) | |||
| ## [v1.1.2](https://bids-specification.readthedocs.io/en/v1.1.2/) (2019-01-10) | |||
|
|
|||
| - REL: v.1.1.2 [#121](https://github.com/bids-standard/bids-specification/pull/121) ([chrisgorgo](https://github.com/chrisgorgo)) | |||
There was a problem hiding this comment.
Suggested change
| - REL: v.1.1.2 [#121](https://github.com/bids-standard/bids-specification/pull/121) ([chrisgorgo](https://github.com/chrisgorgo)) |
src/CHANGES.md
Outdated
| @@ -39,7 +39,7 @@ Changelog | |||
| - \[ENH] Added discontinuous datatype for EEG and iEEG [#286](https://github.com/bids-standard/bids-specification/pull/286) ([wouterpotters](https://github.com/wouterpotters)) | |||
| - \[FIX] Clarify paragraph about custom data types [#264](https://github.com/bids-standard/bids-specification/pull/264) ([effigies](https://github.com/effigies)) | |||
|
|
|||
| ## [v1.2.1](https://github.com/bids-standard/bids-specification/tree/v1.2.1) (2019-08-14) | |||
| ## [v1.2.1](https://bids-specification.readthedocs.io/en/v1.2.1/) (2019-08-14) | |||
|
|
|||
| - Sync rel/1.2.1 to master [#302](https://github.com/bids-standard/bids-specification/pull/302) ([franklin-feingold](https://github.com/franklin-feingold)) | |||
There was a problem hiding this comment.
Suggested change
| - Sync rel/1.2.1 to master [#302](https://github.com/bids-standard/bids-specification/pull/302) ([franklin-feingold](https://github.com/franklin-feingold)) |
effigies
previously approved these changes
Feb 10, 2020
sappelhoff
added
the
exclude-from-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
releasing specification version 1.2.2 following our release protocol