Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] improve wording on data dictionaries #410

Merged
merged 1 commit into from
Feb 24, 2020
Merged

[FIX] improve wording on data dictionaries #410

merged 1 commit into from
Feb 24, 2020

Conversation

sappelhoff
Copy link
Member

closes #387, please see discussion therein.

robertoostenveld
robertoostenveld approved these changes Feb 10, 2020
View reviewed changes
Copy link
Collaborator

@robertoostenveld robertoostenveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the suggested change.

I do not think that the warnings/errors of the continuous integration are due to this small textual change.

effigies
effigies approved these changes Feb 10, 2020
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sappelhoff sappelhoff merged commit 245860d into bids-standard:master Feb 24, 2020
@sappelhoff sappelhoff deleted the wording branch February 24, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@robertoostenveld robertoostenveld robertoostenveld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON data dictionary for TSV is not specific enough
3 participants
@sappelhoff @effigies @robertoostenveld