[INFRA] fix heading of auto changelog to be a markdown header #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklin-feingold
approved these changes
Feb 18, 2020
|
I am merging this now, because it is a minor infrastructure change that may need iterations. Edit: I falsely thought that I could see the changes of this addition upon merging this PR ... however, the changes will only become apparent upon our next release (i.e., upon the next PR that contains However, I did check the change with a local installation of |
|
it works on merged PRs - when a REL is noticed it does not make a new changelog commit appears this works - https://github.com/bids-standard/bids-specification/blob/master/src/CHANGES.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am changing the
header-label [LABEL]parameter to include a#sign, so that hopefully the header of our changelog file will be rendered as an actual header.see: #400 (comment)