-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [ENH] Add section numbers #454
Conversation
No love on the RTD version... from my browser's developer view, I can see that the @sappelhoff: Where is the PDF version found? From the ci I can see that build_docs_pdf was successful, but then seems to be deleted. |
it's here: https://2290-150465237-gh.circle-artifacts.com/0/bids-spec.pdf you need to:
edit: Though it says that it finished 5 hours ago 🤷 might be some weird interaction of time zones? |
It's showing up in the source of the rendered version: <link rel="stylesheet" href="css/section_numbering.css">
<link rel="stylesheet" href="https://assets.readthedocs.org/static/css/badge_only.css">
<link rel="stylesheet" href="https://assets.readthedocs.org/static/css/readthedocs-doc-embed.css">
<link rel="stylesheet" href="css/watermark.css"> And following the link finds the CSS file. It has no effect I can see in Firefox or Chrome. |
Thank you @sappelhoff , @effigies ! Anyway, no love with either the RTD HTML or the PDF. What's maddening, is that the Markdown Publishing Guide has a PDF rendering with full numbering, but I can find no trace of how that's activated in the associated repo (https://github.com/ironmeld/markdown-publishing-guide). (The number isn't present in the RTD HTML, only the PDF, which is annoying, but still partial success.) (Same goes for "markdown-guide Documentation" [HTML] [PDF] [Github Repo]) |
no longer provides preview so can't quickly check. Although I like section numbers etc, I wonder if that would make it also into "fragment" ids, so e.g. https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/02-magnetoencephalography.html#meg-recording-data would become smth like https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/02-magnetoencephalography.html#4.2.2-meg-recording-data . That would then complicate cross referencing specific section a bit since would start to mandate no new sections introduced inbetween existing ones. |
That is a good point @yarikoptic ... in all the examples I can find the HTML has no numbering so it may not be the case that the links need numbering. I still think section numbers would make for a more professional spec, but I don't see how I can make it work via the RTD infrastructure.... so I'm happy to declare failure and put this on moth balls (i.e. close this WIP). |
Hi!! Thanks for all the work done!! |
This is a WIP to address issue #421, adding section and subsection numbers throughout the document.
Will require extensive checking of a RTD and PDF rendered version to ensure it is doing what it should and doesn't have any bad side effects.
RTD rendering: https://bids-specification.readthedocs.io/en/addsectionnums
PDF rendering: (Find via the ci/circleci "build_docs_pdf" job below, expanded under "show all checks", "artifacts" tab; requires Circle CI login)
Note 1. This takes over from PR #453, which came from a personal branch instead of the main repo.
Note 2. The the content for CSS directly copied and pasted from here: https://stackoverflow.com/questions/48029165/is-there-a-way-to-make-the-headings-sections-and-subsections-numbering-in-markd