Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Clarify language on unsetting a key/value pair #495

Merged
merged 3 commits into from
Jun 10, 2020

Conversation

nicholst
Copy link
Collaborator

@nicholst nicholst commented Jun 4, 2020

closes #492 where @Lestropie observed that the current language on inheritance is very confusing.

This small PR simply replaces this (common principles) text

There is no notion of "unsetting" a key/value pair. For example if there is a JSON file corresponding to particular participant/run defining a key/value and there is a JSON file on the root level of the dataset that does not define this key/value it will not be "unset" for all subjects/runs.

with

There is no notion of "unsetting" a key/value pair. Once a key/value pair is set in a given level in the dataset, lower down in the hierarchy that key/value pair will always have some assigned value.

@effigies
Copy link
Collaborator

effigies commented Jun 4, 2020

LGTM.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@sappelhoff sappelhoff modified the milestones: 1.4.0, 1.4.1 Jun 7, 2020
@sappelhoff sappelhoff merged commit aacddc3 into bids-standard:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inheritance principle: unsetting of key-value pairs
3 participants