-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] clarify file formats in EEG, iEEG #511
Conversation
Looks correct to me! PS. @sappelhoff if the invite was to provide for a second reviewer, it gave an error, so I couldn't accept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I like how it clarifies the file triplet/ directory etc. and this lgtm
Thanks both.
yes, the invite was to:
I sent another invitation. |
This time the invitation did work, I accepted |
So... should I do anything on my end to review? :) |
oh sorry --> I already took your previous answer as an "informal" review and that you approve :-) If you want to do a formal review, click on "Files changed" in the top right, and on "Review changes" to approve, request changes, or comment. we also have a guide on this. |
I'm new to the reviewing process over github, so thanks for the explanation :) |
Thanks @MaxvandenBoom. If you want, you could also add yourself to the list of BIDS contributors in our Wiki, which we periodically use to update the contributor list within the specification itself. Given that you provided several fixes for the validator and performed some specification reviewing, i'd say it's high time 🙂 |
I would like that, thanks!! I added myself to the list :) |
closes #476
@dorahermes @MaxvandenBoom this PR is primarily intended to clear up that the MEF3 format is not a
.mef
file, but a.mefd
directory.Do the proposed changes look good to you?