[FIX] Clarify Upper-casing of Channels.tsv Channel Type #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
reviewed
Jul 29, 2020
There was a problem hiding this comment.
Thanks, could you please also adjust the short text that is directory above the channel type keyword list?
i.e., this sentence (screenshot):
Also, in the first sentence after the table, I think we should clarify that this sentence talks about the Other keyword:
sappelhoff
reviewed
Jul 30, 2020
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
sappelhoff
requested review from
agramfort,
dorahermes,
guiomar,
hoechenberger and
jasmainak
hoechenberger
approved these changes
Jul 30, 2020
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
…ography.md Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
…ography.md Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
sappelhoff
approved these changes
Jul 30, 2020
jasmainak
approved these changes
Jul 31, 2020
sappelhoff
reviewed
Aug 2, 2020
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
sappelhoff
reviewed
Aug 2, 2020
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
sappelhoff
reviewed
Aug 2, 2020
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
sappelhoff
approved these changes
Aug 2, 2020
There was a problem hiding this comment.
I made several nitty gritty changes (dot and line breakes) and kept correcting myself .. I should have just checked out the PR and done the changes locally but was too lazy 👼
I'll merge this in now, thanks to @adam2392 and to the reviewers
bids-maintenance
added a commit
that referenced
this pull request
Aug 2, 2020
I feel you 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #534
related validator PR: bids-standard/bids-validator#1022