[INFRA] use --release-branch option in github-changelog-generator #594
Conversation
bump docker version 17.11.0-ce -> 18.06.0-ce bump gh chlog version 1.14.3 -> 1.15.2 add --release-branch param for master add indentation for bash if/else clause
|
Looks reasonable. |
|
okay let's try it. After merging, this line (for example) should disappear from CHANGES.md
|
sappelhoff
changed the title
|
the run has failed because I also upgraded the github-changelog-generator ... and although there were no breaking changes in the API, they do a better job at catching errors now. --> github-changelog-generator/github-changelog-generator#621 and now a silent error in our run has been revealed 🤷♂️ previously, this was a warning, see:
in the last successful build we had prior to merging this present upgrade PR (see "Build Changelog" job and scroll up in the CircleCI log) EDIT: I asked on their gitter channel whether somebody knows how to fix it: https://gitter.im/github-changelog-generator/chat?at=5f57456cec534f584fedf00d |
Due to --since-tag issue. See: bids-standard#594 (comment) And investigation here: https://gitter.im/github-changelog-generator/chat?at=5f57456cec534f584fedf00d This param gets automatically set when using --base, because the "base" file gets parsed for versions. In our case, the latest version in "base" (pregh-changes.md) happens to be 1.1.1, and then --since-tag is automatically set to 1.1.1 and that tag cannot be found in the repository, because we never tagged such a version in git. Alternative options next to downgrading github-changelog-generator are (i) to make a PR against github-changelog-generator and add an option that allows explicitly setting --since-tag to None, or (ii) tagging the first commit of the bids-specification repository as 1.1.1, however the latter would be a weird hack.
closes #559
--release-branchparam formasterIt seems straight forward enough. If I remember correctly, @franklin-feingold's only problem was to test whether this actually works as expected.
I didn't test it, but if we merge this and see that it doesn't work, we can revert the changes. WDYT @effigies ?