Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Allow encoding the fieldmapping intent of the protocol #622

Merged
merged 7 commits into from
Apr 28, 2021

Commits on Apr 5, 2021

  1. enh: allow encoding the fieldmapping intent of the protocol

    This PR addresses the problem @mattcieslak spotted at in bids-standard#239.
    
    This enhancement (WIP) basically allows for researchers to encode
    the protocol's intent regarding fieldmaps.
    
    As @satra introduced in bids-standard#239 (comment),
    BIDS "*could encode intent and automation. Whether it should is a community decision."
    
    This PR proposes a solution to encoding the intent. It doesn't modify
    anything to allow also encoding automation.
    
    The PR attempts to be backwards compatible, and is based off of bids-standard#651,
    where the text about fieldmaps is being revised.
    
    I'm submitting this draft PR to open discussions and looking forward to
    feedback.
    
    Resolves: bids-standard#239.
    Depends: bids-standard#651.
    References: #263, nipreps/dmriprep#43, bids-standard/bids-2-devel#39
    oesteban committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    c44b926 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    oesteban and effigies committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    1aec168 View commit details
    Browse the repository at this point in the history
  3. enh: miscellaneous changes (see below)

    - Added suggestion of deriving the `B0FieldIdentifier` from the Protocol Name DICOM tag
    - Introduce "imaging" into Spiral-Echo Imaging mention (and update acronym to SEI)
    - Add `B0FieldIdentifier` definitions to metadata examples of fieldmaps
    - Reorder fieldmap spec - place metadata (`B0FieldIdentifier` and `IntendedFor` before fieldmap types)
    - Add link to the new general section where `B0FieldIdentifier` is introduced.
    oesteban committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    9664f8f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5be9e5f View commit details
    Browse the repository at this point in the history
  5. fix: remove 'e.g.'

    oesteban committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    702d8b9 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Configuration menu
    Copy the full SHA
    8377588 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Configuration menu
    Copy the full SHA
    8d862e7 View commit details
    Browse the repository at this point in the history