Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] replace "e.g.," by "for example" #626

Merged
merged 4 commits into from
Oct 2, 2020

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Sep 29, 2020

  • replace "e.g." by "for example"
  • linting of tables
  • linting of line length
  • ensure that wihin a paragraph new sentences start on a new line

@effigies
Copy link
Collaborator

@Remi-Gau Before we go too far, I think we should probably verify that this is an accessibility improvement. I believe I got this recommendation from The Turing Way Style Guide, but I'm having trouble finding the justification in their reference, or other accessibility websites. It's possible that e.g. and so forth are no longer considered inaccessible?

Maybe @KirstieJane (or some other representative) could clarify the situation?

@arokem
Copy link
Collaborator

arokem commented Sep 29, 2020

I think that the key sentence in that style guide is "eg can sometimes be read aloud as ‘egg’ by screen reading software"

@effigies
Copy link
Collaborator

Ah, yup:

eg, etc and ie

eg can sometimes be read aloud as ‘egg’ by screen reading software. Instead use ‘for example’ or ‘such as’ or ‘like’ or ‘including’ - whichever works best in the specific context.

etc can usually be avoided. Try using ‘for example’ or ‘such as’ or ‘like’ or ‘including’. Never use etc at the end of a list starting with these words.

ie - used to clarify a sentence - is not always well understood. Try (re)writing sentences to avoid the need to use it. If that is not possible, use an alternative such as ‘meaning’ or ‘that is’.

I was searching for "e.g." and "latin", so missed that.

@tsalo
Copy link
Member

tsalo commented Sep 29, 2020

So is it enough to just make sure that we use "e.g." instead of "eg" (which is a typo I think we'd catch during PR review anyway)?

@Remi-Gau
Copy link
Collaborator Author

I think that for non-native speakers, avoiding e.g. and using 'for example' might be more transparent.

@PeerHerholz
Copy link
Member

I think that for non-native speakers, avoiding e.g. and using 'for example' might be more transparent.

+1 on that, I experienced issues with that as well.

@Remi-Gau Remi-Gau marked this pull request as ready for review September 29, 2020 16:15
@Remi-Gau Remi-Gau linked an issue Sep 29, 2020 that may be closed by this pull request
@sappelhoff sappelhoff added this to the 1.4.1 milestone Sep 29, 2020
Release_Guideline.md Outdated Show resolved Hide resolved
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks a bunch @Remi-Gau

I think the Turing way style guide also has a point with "etc" --> it's really seldom necessary (if ever) to use "etc" 🤔 perhaps we can remove that from the spec in another PR.

@Remi-Gau
Copy link
Collaborator Author

I think the Turing way style guide also has a point with "etc" --> it's really seldom necessary (if ever) to use "etc" thinking perhaps we can remove that from the spec in another PR.

Oh no! that's going to be the source of more insomnia for me. :-p

Will take care of it. :-)

@effigies
Copy link
Collaborator

effigies commented Oct 2, 2020

I'd suggest going ahead and merging this sooner than later, since it's semantically neutral and is going to generate merge conflicts.

@sappelhoff sappelhoff merged commit 632de87 into bids-standard:master Oct 2, 2020
@sappelhoff
Copy link
Member

I'd suggest going ahead and merging this sooner than later, since it's semantically neutral and is going to generate merge conflicts.

agreed.

Thanks a lot @Remi-Gau

@Remi-Gau Remi-Gau deleted the remi-fix_eg_example branch October 2, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "e.g." in the spec to "for example"
6 participants