[INFRA] set up github action to detect latin phrases #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: you get plenty of errors when running the script locally but the github action passes because on a PR it will only look for files modified in |
2 tasks
effigies
reviewed
Oct 4, 2020
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Remi-Gau
commented
Oct 5, 2020
sappelhoff
reviewed
Oct 5, 2020
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
effigies
approved these changes
Oct 5, 2020
|
Infrastructure, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to the issue #635 .
fixes #635
TODO
Adapting the code from the Turing way was actually easier than anticipated.
script
The way this is set up, this should look through the files in the
srcfolder ignoring the files with extensions listed inget_all_filesand look for lines that contain the expressions listed inread_and_check_files.Comments lines are skipped.
Files added to the
srcfolder in a PR are also checkedgithub action
It will trigger the script :
srcfor reviewers
My python is far from fluent so a cross check would be good. 🙏
Any suggestions on how to smartly test a github action? Should I merge into this onto my own master to give this a go.This seems to be set up directly even in this PR. Never mind.