[FIX] consistent CoordinateSystem fields for ephys #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
added
MEG
sappelhoff
requested review from
robertoostenveld,
choldgraf,
dorahermes and
jasmainak
robertoostenveld
approved these changes
Oct 8, 2020
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
hoechenberger
approved these changes
Oct 8, 2020
effigies
reviewed
Oct 8, 2020
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
good point, thank you, done! |
effigies
approved these changes
Oct 8, 2020
|
lgtm |
hoechenberger
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to increase the consistency between MEG, EEG, and iEEG for the
*CoordinateSystemand*CoordinateSystemDescriptionfields.The effort is intended as a preparation for stronger validation of these fields (see bids-standard/bids-validator#945).
All of the changes are intended to be clarifications, no modifications or enhancements.
For MEG, I took a relatively hidden paragraph on simultaneous EEG acquisition and turned it into its own section.
@bids-standard/raw-electrophys