Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixing template string on electrodes for eeg and ieeg. #650

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

adam2392
Copy link
Member

Summary

Closes: #649

Fixes the template strings in the modality-specific spec to match that of https://bids-specification.readthedocs.io/en/stable/99-appendices/04-entity-table.html#encephalography-eeg-ieeg-and-meg

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@sappelhoff
Copy link
Member

This is in accordance with the entity table: https://bids-specification.readthedocs.io/en/latest/99-appendices/04-entity-table.html#encephalography-eeg-ieeg-and-meg ... so this is truly a fix.

unfortunately, as discussed in this issue comment, the validator is not precise enough to validate this. So the validator will still accept files like: *_task-Nonsense_electrodes.tsv. There is a similar issue here: bids-standard/bids-validator#848

Still +1 to merge, then adjust mne-bids (mne-tools/mne-bids#604), and then eventually improve the validator (better sooner than later)

@sappelhoff sappelhoff merged commit 14263cf into bids-standard:master Oct 29, 2020
@sappelhoff
Copy link
Member

Thanks @adam2392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Templating issue: should electrodes.tsv and coordsystem.json writing per eeg/ieeg only have certain entities?
2 participants