Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Move part entity to before recording entity #692

Merged
merged 1 commit into from
Dec 8, 2020
Merged

[INFRA] Move part entity to before recording entity #692

merged 1 commit into from
Dec 8, 2020

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Dec 7, 2020 •
edited
Loading

Closes None, but addresses an issue raised in the maintainers Mattermost channel.

Changes proposed:

  • Move part entity to before recording entity, so that it fits with other related entities (e.g., echo, inv, flip). Note that this shouldn't impact any filenames, as recording and part shouldn't be present in the same filename.
  • Rebuild entity table and entity description appendices.

@tsalo
Reorder part in list of entities.
dce1475 
This places part *before* recording, so that it fits with other related entities (e.g., echo, inv, flip).

This shouldn't impact any filenames, as recording and part shouldn't cooccur in the same filename.
effigies
effigies approved these changes Dec 7, 2020
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part- wasn't in a release, and I also can't find any cases where they show up together, so I think it would be safe anyway.

@agahkarakuzu
Copy link
Contributor

@tsalo good catch!
image

I was about to open an issue about this :)

@tsalo
Copy link
Member Author

tsalo commented Dec 8, 2020

It looks like the linkchecker failure is unrelated to the changes in this PR. Should I just merge as-is?

@tsalo tsalo mentioned this pull request Dec 8, 2020
Closed
agahkarakuzu added a commit to bids-bep001/bids-specification that referenced this pull request Dec 8, 2020
@agahkarakuzu
Entity and entity tables
c800f3a 
- Avoid conflict with bids-standard#692 
- Add applicable TB1map file collections
@sappelhoff
Copy link
Member

It looks like the linkchecker failure is unrelated to the changes in this PR. Should I just merge as-is?

👍

@tsalo tsalo merged commit f3b52ac into bids-standard:master Dec 8, 2020
@tsalo tsalo deleted the reorder-part branch December 8, 2020 14:20
bids-maintenance added a commit that referenced this pull request Dec 8, 2020
@bids-maintenance
[DOC] Auto-generate changelog entry for PR #692
8e72425
sappelhoff pushed a commit to bids-bep001/bids-specification that referenced this pull request Dec 21, 2020
@agahkarakuzu @sappelhoff
Entity and entity tables
1d8db2b 
- Avoid conflict with bids-standard#692 
- Add applicable TB1map file collections
effigies added a commit that referenced this pull request Jan 13, 2021
@agahkarakuzu @tsalo
@effigies @Gilles86 @sappelhoff
[ENH] BEP001 - qMRI maps and some additional metadata (#690)
7a10ce1 
* Edit non-param table, add legacy list

* Add table for parametric maps

* Add description for parametric maps.

* Add templates for file collections

* Typo, wording for NumberShots

* Add spoiling metadata

* Update entity schema src

* split

* Update src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md

Co-authored-by: Taylor Salo <tsalo006@fiu.edu>

* Wording

* a.u. --> arbitrary

* legacy --> deprecated

* mod --> label

* ADD explanations about fundamental contrasts

* Drop part from qMaps

* update entity table

* STY: Use .md links, fix table formatting

* Update src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* [ADD] qMRI Appendix

* ADD SA2RAGE and qMRI appendix links

* Entity and entity tables

- Avoid conflict with #692 
- Add applicable TB1map file collections

* ADD MixingTime & Improve NumberShots

* Consistency

* Address comment

* map units

* Super minot textual edits

* Some small textual fixes in 10-file-collections

* re-render entity table after rebase

using  python tools/bids_schema.py entities src/schema/ src/99-appendices/04-entity-table.md

* fix call to use entitytable, not entities

* fix 09-entities using correct schema call

* Drop latin phrases

* Fix double quotes

* Codeblock type fix

* Fix article hyperlinks --> DOI

* Punctuation fixes

* Add section links iof italics

* Drop etc.

* Rm Latin phrase

* add missing newline at end of file

* major syntax+linebreak overhaul qmri appendix

* remaining qmri appendix syntax issues, except one to be discussed

* fix table pipes in 10-file-collections.md

* fix ill-formatted links

* some more link fixes

* one more link

* Fix typo

* Fix parantheses

* Make spoiling-relevant requirements more explicit

* Wording suggestion

* Add unit for MixingTime

* Fix typo

* Define R1,R2,R2star and re-arrange rows

* Fix double quotes

* Fix typo

* Wording suggestion

* Rm verbosity

* Wording fix

* Number of shots array/number explanation

* Update src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/99-appendices/11-qmri.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Update src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* fix links by converting to lowercase

* STY: Align table fences

* STY: Fix link syntax, one more table fence

* Fix typo

* Fix paranthesis

* STY: Align table fences

* Move UNIT1 to non-parametric table

* Fix typo

* Fix typo

* Drop the term grayscale

* Align table fence

* STY: Align table fences

Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Gilles de Hollander <Gilles.de.Hollander@gmail.com>
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@tsalo tsalo added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@sappelhoff sappelhoff sappelhoff approved these changes

Assignees
No one assigned
Labels
schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsalo @agahkarakuzu @sappelhoff @effigies