Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Migrate md and yml checks from travis to GH actions #693

Merged
merged 13 commits into from
Dec 10, 2020

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Dec 8, 2020

closes #685

this should fix the annoying problems that:

  1. the travis check stopped consistently appearing as a check in the GitHub UI
  2. bandwidth limits with travis (though we might run into that with GH actions as well, not sure.)

NOTE

this also changes a "NOT RECOMMENDED" part in appendix VIII to use "DEPRECATED", as previously discussed in maintainers mattermost channel.

@sappelhoff
Copy link
Member Author

okay finally everything works. The Markdown check fails due to reasonable issues that we missed with travis' outages.

ready to be merged if you agree @effigies

.github/workflows/markdown_style.yml Outdated Show resolved Hide resolved
.github/workflows/markdown_style.yml Outdated Show resolved Hide resolved
.github/workflows/yml_lint.yml Outdated Show resolved Hide resolved
@effigies
Copy link
Collaborator

effigies commented Dec 8, 2020

Should we go ahead and resolve the style issues in this PR?

@sappelhoff
Copy link
Member Author

Should we go ahead and resolve the style issues in this PR?

I think the remaining style issues are all in the MRI md file and should be resolved as part of BEP005 to avoid rebasing/conflict trouble

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@effigies effigies merged commit 2bb67d8 into bids-standard:master Dec 10, 2020
@sappelhoff sappelhoff deleted the ghact branch December 10, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate "Travis CI" service to "GitHub Actions" CI service
3 participants