Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] refactor stimuli mentioning sections in the events page #697

Merged
merged 10 commits into from
Apr 14, 2021
Merged

[MISC] refactor stimuli mentioning sections in the events page #697

merged 10 commits into from
Apr 14, 2021

Conversation

Remi-Gau
Copy link
Collaborator

PR related to #695

  • moves all sections about stimuli (whether about the stimuli folder or the database) together (including specific column names from the first table).

This is a draft looking for suggestions for improvements.

Also included

  • adding data types in the first table (leaving some ???? for values I am unsure about)

Questions

  • should the identifier and database columns be included in the tables of column names or were they there as just suggestions for the example?
  • the database column is not described in the example JSON: should this be fixed?

@Remi-Gau Remi-Gau mentioned this pull request Feb 21, 2021
Merged
7 tasks
@Remi-Gau Remi-Gau changed the title [WIP] refactor stimuli mentioning sections in the events page [MISC] refactor stimuli mentioning sections in the events page Feb 21, 2021
@Remi-Gau Remi-Gau marked this pull request as ready for review February 21, 2021 13:36
@tsalo tsalo self-requested a review March 2, 2021 18:32
@effigies effigies added this to the 1.6.0 milestone Mar 2, 2021
@VisLab
Copy link
Member

VisLab commented Mar 2, 2021

The HED column type is a string.

@Remi-Gau
Copy link
Collaborator Author

@effigies @sappelhoff

Except for this failing link in a file I did not touch, this is good to go.

sappelhoff
sappelhoff approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Remi-Gau

@sappelhoff sappelhoff merged commit 929d137 into bids-standard:master Apr 14, 2021
bids-maintenance added a commit that referenced this pull request Apr 14, 2021
@bids-maintenance
[DOC] Auto-generate changelog entry for PR #697
6b37242
@Remi-Gau Remi-Gau mentioned this pull request Apr 14, 2021
Closed
@Remi-Gau Remi-Gau deleted the remi-stiumli_folder branch November 15, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@sappelhoff sappelhoff sappelhoff approved these changes

@VisLab VisLab Awaiting requested review from VisLab

@tsalo tsalo Awaiting requested review from tsalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Remi-Gau @VisLab @effigies @sappelhoff