[ENH] Harmonize CoordinateSystem details for MRI, MEG, EEG, iEEG #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
requested review from
effigies,
adam2392,
dorahermes,
ftadel and
robertoostenveld
sappelhoff
added
consistency
adam2392
approved these changes
Jan 28, 2021
dorahermes
reviewed
Jan 28, 2021
effigies
approved these changes
Jan 28, 2021
tsalo
reviewed
Jan 29, 2021
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
|
Thanks for the review everyone. |
sappelhoff
added a commit
to sappelhoff/bids-specification
that referenced
this pull request
Feb 1, 2021
…-standard#717) * harmonize coordsystems * fix table pipe * remove two typos * fix typo * text clarifications Co-authored-by: Taylor Salo <tsalo006@fiu.edu> Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
sappelhoff
added a commit
that referenced
this pull request
Feb 1, 2021
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pruned down version of #700
This PR contains uncontroversial (well, you be the judge) changes only.
<datatype>CoordinateSystemto<CoordSysType>CoordinateSystem, because we use datatype differently in the spec, and given a "FiducialsCoordinateSystem", it's more reasonable to call "Fiducials" a "CoordSysType" rather than a datatypeSee the accompanying validator changes that are required in this PR: bids-standard/bids-validator#1149
Allow MEG keywords for EEG (and vice versa)
When recording EEG together with MEG (which happens rather often), the EEG electrode coordinates are very often digitized in the same coordinate system as the MEG sensors. Currently, we have permissible keywords for MEG and EEG separate.
I changed this in the spec: Now, when users record MEG+EEG, they can specify the CoordinateSystem for EEG with MEG keywords.
see also bids-standard/bids-examples#217 (comment)
Allow any "Standard template identifiers"
At least in iEEG it is apparently common to transform the sensor coordinates to some standard template, as specified in our table in appendix VIII. So far, the keywords in that table were not explicitly mentioned to be valid keywords for CoordinateSystem fields.
I changed that: MEG, EEG, and iEEG users are now free to transform their coordinates to any standard template, and then use the respective keywords as a value to the CoordinateSystem field.
I don't think this will commonly be used in MEG or EEG, but I may be wrong and it doesn't hurt to stay consistent between (i)MEEG.
to do