[FIX] Correct schema irregularities for func datatype #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These entities dissociate functional runs, so we need to allow them for physio/stim data in order to connect the continuous data to the imaging data.
tsalo
added
the
schema
effigies
approved these changes
Feb 9, 2021
|
One note- I need to rename the suffix groups to match those in the validator before merging this. EDIT: Done! |
bids-maintenance
added a commit
that referenced
this pull request
Feb 10, 2021
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None, but stems (in part) from bids-standard/bids-validator#1125 (comment).
Changes proposed:
echoentity and_eventssuffix. The echo entity delineates files within an imaging run, so it shouldn't be used for associated files that apply to the whole run.ceanddirentities withfunc/continuous data (the_physioand_stimsuffixes). These entities distinguish imaging runs, so they are required to link the continuous data to the imaging scan.sub-X_task-Y_dir-AP_bold.nii.gz,sub-X_task-Y_dir-PA_bold.nii.gz, andsub-X_task-Y_physio.tsv.gz, and there would be no way to know which BOLD scan the physio is associated with.