[FIX] schema for i/eeg coordsys+elecs: sub-ses-acq-space are allowed entities

[sappelhoff]

while opening bids-standard/bids-validator#1198 I noticed some inconsistencies in our schema.

Q&A about the changes in this PR.

• Q: Why adding "space" to EEG coordsystem.json and "acq" to iEEG coordsystem.json?
  • A: coordsystem.json contains metadata for electrodes.tsv ... so it must support the same entities as electrodes.tsv
  • "space" is used to distinguish files from different "coordinate spaces"
  • "acq" is used for something like "coordinates digitized pre or post recording" -> acq-pre, acq-post
• Q: Why allow electrodes.json?
  • A: that file explains additional arbitrary columns in electrodes.tsv ... these are not added to coordsystem.json, which has a restricted set of metadata that can/must be specified
• And the remaining change is just for consistency, that space comes after acq in a file name.

---

I still have to rebuild the entitiy table, but I keep running into issues. @tsalo what's the current way to call the script (see also #696 )?

...:~/Desktop/bids/bids-specification$ python tools/schemacode/schema.py entities src/schema/ src/99-appendices/04-entity-table.md
Traceback (most recent call last):
File "tools/schemacode/schema.py", line 12, in
from . import utils

[tsalo]

As of now, there is no command line integration for the schema functions. However, since we merged #610, you just need to render the specification locally, or check the CI, to check the updated entity table and filename patterns.

[sappelhoff]

oh I completely forgot that this was removed in #610. I'll close #696 based on that. thanks.

This is ready for review/merging then.

[tsalo]

I checked the rendered filename patterns and the entity table, and it all looks good to me.

[sappelhoff]

Thanks for the review Taylor and Adam!