Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Mix up (typo) between ficiduals and landmarks in EEG spec #754

Merged
merged 1 commit into from
Mar 13, 2021
Merged

[FIX] Mix up (typo) between ficiduals and landmarks in EEG spec #754

merged 1 commit into from
Mar 13, 2021

Conversation

rob-luke
Copy link
Member

I think this is a typo. But I may also just be confused.

yarikoptic
yarikoptic approved these changes Mar 13, 2021
View reviewed changes
Copy link
Collaborator

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a correct fix to me (like a left over from some renaming), but I am not familiar with eeg portion of the spec

sappelhoff
sappelhoff approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sappelhoff sappelhoff changed the title [FIX]: Mix up between ficiduals and landmarks in EEG spec [FIX] Mix up (typo) between ficiduals and landmarks in EEG spec Mar 13, 2021
@sappelhoff sappelhoff merged commit 4f887b8 into bids-standard:master Mar 13, 2021
@sappelhoff
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic approved these changes

@sappelhoff sappelhoff sappelhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rob-luke @sappelhoff @yarikoptic