Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Amend note about *b*-vecs on DWI specs #782

Merged
merged 1 commit into from
May 27, 2021

Conversation

oesteban
Copy link
Collaborator

Although this note is true (and the b-vecs should be rotated through the head-motion parameters), it is describing some post-processing step.

The actual implication w.r.t. BIDS of the choice of this format is that, if the scanner generates (or better said, receives and forwards) b-vecs in "world coordinates", then they need to be converted into voxel coordinates before writing into BIDS.

BIDS should describe only how the data & metadata should/could be stored. AFAICT, it should not prescribe how to use them whenever possible.

Comes from mattcieslak#1 (comment)

@mattcieslak
Copy link
Contributor

I've been thinking about this note and you're right the head motion rotations shouldn't be mentioned here. Having curated tons of data in BIDS, the main issue we run into with bvecs is the image axis orientation. For example, oblique acquisitions effectively mandate that a bvec file exists for every scan while plumb acquisitions can inherit bvecs from higher up. Not sure if this is worth noting in the main BIDS spec though

@oesteban
Copy link
Collaborator Author

For example, oblique acquisitions effectively mandate that a bvec file exists for every scan while plumb acquisitions can inherit bvecs from higher up.

What do you mean that "oblique acquisitions effectively mandate that a bvec file exists for every scan"? You mean that the conversion tool has ensured that the bvecs have been converted into voxel coordinates? (and hence make sure the bvec file is generated for every dwi). And then plumb datasets are assumed to be already in voxel coordinates and hence just one is placed at the top level, when a flip of an axis could exist?

Not sure if this is worth noting in the main BIDS spec though

My question above may be put in simpler terms: the problem here is representing the gradients with BIDS or something that conversion tools perhaps should pay more attention to? (or alternative, get #352 merged and do not rely on the conversion tool to do this correctly, as you have been indeed proposing for a long while).

@mattcieslak
Copy link
Contributor

In studies where the scanner operator gets to angle the FoV to capture the participant's brain, each subject gets a unique transform from the requested gradients into image coordinates. So instead of being able to use the inheritance principle the bvecs will be very different for each subject. PIs are often surprised that they can't use one bvec file even though they used the same sampling scheme for every subject because the bvecs need to be transformed for each subject's custom oblique FoV.

dcm2niix and other tools do a great job getting correct bvecs in image coordinates, I was thinking maybe a note would be useful to point this out?

@oesteban
Copy link
Collaborator Author

dcm2niix and other tools do a great job getting correct bvecs in image coordinates, I was thinking maybe a note would be useful to point this out?

I'm totally +1 on this. But I would rather state it within #352, and add ammo to the arguments being discussed. WDYT?

I'd like to keep this one focused on not saying something that is not helpful in the current spec.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIDS should describe only how the data & metadata should/could be stored. AFAICT, it should not prescribe how to use them whenever possible.

I never worked with this data, but I agree with the general statement and the changes look good.

@sappelhoff sappelhoff changed the title FIX: Amend note about *b*-vecs on DWI specs [FIX] Amend note about *b*-vecs on DWI specs May 22, 2021
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems both reasonable and, to the best of my understanding, correct.

@sappelhoff sappelhoff merged commit 0173854 into bids-standard:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants