Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] make "Institutional department name" available for all datatypes #839

Merged

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Jul 30, 2021

This PR is to keep in synch with changes on the validator and explicitly makes "Institutional department name" available for all modalities: it was included in the EEG and MEG json schema of the validator but not in the specs.

https://github.com/bids-standard/bids-validator/pull/1312

@sappelhoff sappelhoff changed the title make "Institutional department name" available for all datatypes [ENH] make "Institutional department name" available for all datatypes Jul 30, 2021
@sappelhoff
Copy link
Member

@Remi-Gau I just merged #804 - if you address the last point in your to do list, we can merge this PR as well.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Aug 2, 2021

@Remi-Gau I just merged #804 - if you address the last point in your to do list, we can merge this PR as well.

done

@sappelhoff sappelhoff merged commit 49fb25d into bids-standard:master Aug 2, 2021
@sappelhoff
Copy link
Member

Thanks again @Remi-Gau

@Remi-Gau Remi-Gau deleted the institutional_department_name branch November 15, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants