-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] dos2unix #859
[INFRA] dos2unix #859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
Ouch, I had forgotten the 5 days rule. Sorry about that. Since it is a very simple INFRA change, I hope this won't matter. |
indeed :-) good that you remembered it now. I agree though that for this simple INFRA change it's absolutely fine to merge after two maintainer approvals. Thanks for the fix. If you find a simple way to extend our current CI to check for line endings (and error upon inconsistency), such a PR would be welcome. |
But now it is creating a merge conflict on my "tree example" PR. 😭 Just kidding. I am sure I will survive. #Drama |
I had a very hard time rebasing after this "dos2unix". Ended up re-creating each commit :-( |
To fix conflicts, after
|
I have nothing against CRLF line endings, but I am all for consistency.
This was the only text file in the whole repository with such line endings.