Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add "ScanRAS" as an accepted coordinate frame for ieeg #866

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

alexrockhill
Copy link
Contributor

Fixes #747.

@tsalo
Copy link
Member

tsalo commented Sep 1, 2021

ScanRAS will also need to be added to the list of acceptable iEEG coordinate systems in the schema:

---
type: string
enum:
- Pixels
- ACPC
- Other

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after Taylors comment has been addressed

Also, I feel like this thread should be merged PRIOR as well: fieldtrip/website#444

@alexrockhill
Copy link
Contributor Author

Ok sorry this took so long, I added ScanRAS and Robert merged the other PR so this may be next

@sappelhoff sappelhoff merged commit 7d21713 into bids-standard:master Sep 9, 2021
@sappelhoff
Copy link
Member

Thanks @alexrockhill

@sappelhoff sappelhoff changed the title [ENH, MRG] Add "ScanRAS" as an accepted coordinate frame for ieeg [ENH] Add "ScanRAS" as an accepted coordinate frame for ieeg Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storing iEEG electrodes with locations from FreeSurfer image
3 participants