[INFRA] tiny speedup of building PDF by moving re.compile()
outside of a loop
#896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5de7cfc / #774 changed:
bids-specification/pdf_build_src/process_markdowns.py
Line 447 in b45d99e
into:
bids-specification/pdf_build_src/process_markdowns.py
Line 448 in 5de7cfc
If the intent was only to add
DOTALL
, I believe this would have been sufficient:If the intent was to use
re.compile()
for efficiency, thenre.compile()
must be moved outside the loop.