Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Clarify that EDF/BDF files MUST have lower case extensions in BIDS #927

Merged
merged 9 commits into from
Nov 17, 2021

Conversation

adam2392
Copy link
Member

From bids-standard/bids-validator#1381, we now clarify that the EDF files should be lower-case extension.

@sappelhoff sappelhoff changed the title Fix EDF spec to require lower-case extension [FIX] Clarify that European data format .edf files MUST have lower case extension in BIDS Nov 12, 2021
@sappelhoff sappelhoff added EEG Electroencephalography iEEG labels Nov 12, 2021
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Adam!

Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a very small fix for a typo and some misaligned table fences.

This LGTM. Thanks!

@effigies effigies changed the title [FIX] Clarify that European data format .edf files MUST have lower case extension in BIDS [FIX] Clarify that EDF/BDF files MUST have lower case extensions in BIDS Nov 15, 2021
@sappelhoff sappelhoff merged commit 9b43833 into bids-standard:master Nov 17, 2021
effigies added a commit to effigies/bids-specification that referenced this pull request Nov 17, 2021
…IDS (bids-standard#927)

* Fix EDF spec

* drop latin, use 'lower case' without dash -

* Update src/04-modality-specific-files/03-electroencephalography.md

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* Convert to table

* Format table

* add missing dots

Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>

* add missing code formatting, one consistency fix

* Fix reviews

* STY: Fix typo, table fences

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Co-authored-by: Christopher J. Markiewicz <markiewicz@stanford.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EEG Electroencephalography iEEG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants