Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add links from derivatives section to entity list #936

Merged
merged 2 commits into from
Dec 4, 2021

Conversation

sappelhoff
Copy link
Member

closes #920

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it might be also worth adding links in the common data types page too, no?

https://bids-specification.readthedocs.io/en/latest/05-derivatives/02-common-data-types.html

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disregard my previous comment : I am not sure what I was looking at to miss the changes in all the files...

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sappelhoff sappelhoff merged commit 71ecd41 into bids-standard:master Dec 4, 2021
@sappelhoff sappelhoff deleted the fix/links/derivs-entity branch December 4, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure entities in the derivatives pages are linked to the entities appendix
3 participants