Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] relax unrealistically strict requirements with ieeg channels.tsv 'name' column #938

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

sappelhoff
Copy link
Member

closes #893

I consider this PR a bugfix, see the three first comments in #893.

Copy link
Collaborator

@robertoostenveld robertoostenveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good improvement now

Copy link
Member

@dorahermes dorahermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sappelhoff sappelhoff merged commit 061f22d into bids-standard:master Dec 7, 2021
@sappelhoff sappelhoff deleted the fix/ieeg/bipolar branch December 7, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misunderstanding in iEEG electrodes.tsv description of "name" column?
5 participants