[FIX] number of small corrections to the specification

[robertoostenveld]

These are mostly formatting changes and fixes to external links.

[yarikoptic]

This ain't a complete review, but a few notes how to make PR better ;)
THANK YOU btw -- we should indeed polish up the spec so there is no place for ambiguity and errors like the ones you (and now me ;-) ) point out!

[chrisgorgo]

Thanks for sending this along, FYI - here are the linter errors Travis spotted: https://travis-ci.com/bids-standard/bids-specification/builds/92812807

[yarikoptic]

FWIW +1 on formalizing to use American English, and mention that in common principles of it isn't there yet

[chrisgorgo]

Contributors guide would be a better place to put such recommendation.

…

On Thu, Nov 29, 2018, 5:41 AM Yaroslav Halchenko ***@***.*** wrote: FWIW +1 on formalizing to use American English, and mention that in common principles of it isn't there yet — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#98 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOkp_ayZf7GtHdknkOJh-iTjl6IaZ9pks5uz-QFgaJpZM4Y3Hqq> .

[yarikoptic]

@robertoostenveld would you have time to resolve outstanding issues causing CIs to fail? I think we are ready otherwise and should merge!

[yarikoptic]

@robertoostenveld - I have pushed a commit resolving introduced problems. If would be all kosher - I would merge or we would be in jeopardy to introduce conflicts

[robertoostenveld]

The Christmas period delayed work on this. I have updated to the HEAD of the master branch and resolved the conflicts. I see that circleci passes, but that travis fails: I will investigate.

[robertoostenveld]

Whereas travis initially was showing "Incorrect list-item indent: add 2 spaces", after me changing it it to 2 spaces it was showing "Incorrect list-item indent: add 1 space". Also the table fence around the emojis seems impossible to get right. I am lost!

Content wise it all seems fine to me, so I suggest to merge.

[chrisgorgo]

Consider using https://github.com/prettier/prettier to automatically fix syntax

[robertoostenveld]

... so I managed to get all checks to pass!

@chrisfilo: the opinion of prettier regarding the table fence turns out not consistent with that implemented using remark-lint in Travis. I guess it is because the different emoji having different byte counts, and the tools not agreeing on how this is to be dealt with.

Furthermore, remark-lint gives me Error: Could not find module lint-list-item-indent, both on the command line and in Atom. So linting - although a nice idea - does not work for me (as a non computer scientist). I wonder how other neuroscientists are dealing with this, especially the ones for whom WordPad is the default tool for the editing of text files.

[chrisgorgo]

I agree, but this is a good topic for a new issue (perhaps proposing less strict linting).

[chrisgorgo]

@yarikoptic @robertoostenveld is this read to merge?

[sappelhoff]

Looks good to me ... except for in the contributors file, where a line seems to be removed: If you can tell me why (or fix this "typo"), I can approve and merge this.

[robertoostenveld]

this is ready to merge.

[yarikoptic]

Looks good to me. Thanks!

[chrisgorgo]

@yarikoptic thanks.

This is minor, but please wait 5 days since the last commit before merging next time (as per https://github.com/bids-standard/bids-specification/blob/master/DECISION-MAKING.md#rules). At least until someone automates this (see #147).

[yarikoptic]

Ok, noted