[FIX] update definition acq_time for sessions.tsv

[Remi-Gau]

fixes #948

• simplify acq_time definition by removing sections that are redundant with the Unit section
• give different restrictions for scans.tsv and sessions.tsv

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@d611689). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #986   +/-   ##
=========================================
  Coverage          ?   35.13%           
=========================================
  Files             ?        8           
  Lines             ?      834           
  Branches          ?        0           
=========================================
  Hits              ?      293           
  Misses            ?      541           
  Partials          ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d611689...03a5604. Read the comment docs.

[sappelhoff]

Thanks! This is how I imagined it as well. 👍 Let's see what Taylor says about pulling schema description out of the schema and into the macro call.

[tsalo]

I'm not sure what the best way to describe this is, but I do think that the description needs to have meaningful information about the field, or else efforts like BIDS-Terms and our glossary won't be very effective. I almost think that it would be better to split the definition into multiple senses if there's no way to write a single interpretable description that only undergoes minor modifications in the tables.

WDYT of just using acc_time__sessions and acq_time__scans?

[Remi-Gau]

@tsalo I think this should be done.

[tsalo]

LGTM!

[sappelhoff]

Thanks @Remi-Gau