Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add physio/stim files to ASL and PET rules #1560

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

effigies
Copy link
Collaborator

@effigies effigies changed the title ENH: Add physio/stim files to ASL rules ENH: Add physio/stim files to ASL and PET rules Nov 13, 2022
@marcelzwiers
Copy link

And pet as well?

>>> bids_validator.BIDSValidator().is_bids('/sub-foo/pet/sub-foo_task-name_pet.json')
True
>>> bids_validator.BIDSValidator().is_bids('/sub-foo/pet/sub-foo_task-name_physio.json')
False

@effigies
Copy link
Collaborator Author

That's using this branch?

@marcelzwiers
Copy link

Sorry, I got some errors when I tried to install this branch and didn't test it. I just wanted to add the pet example so you could easily test it yourself if you wanted to. I suppose your PR fixes it

@effigies
Copy link
Collaborator Author

Gotcha. I did test your string and it passes.

@rwblair rwblair merged commit 97feb8b into bids-standard:master Nov 14, 2022
@effigies effigies deleted the enh/asl_physio branch November 14, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants