Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename udev rule #99

Closed
wants to merge 1 commit into from
Closed

refactor: rename udev rule #99

wants to merge 1 commit into from

Conversation

wucke13
Copy link

@wucke13 wucke13 commented May 20, 2024

This fixes #98. Essentially, the processing of udev rules in lexical order rendered the TAG+="uaccess" in the IMSProg udev rule useless. This commit fixes it by renaming the rules file, causing it to be processed before the internal handling of udev's uacccess.

This fixes #98. Essentially, the processing of udev rules in lexical
order rendered the `TAG+="uaccess"` in the IMSProg udev rule useless.
This commit fixes it by renaming the rules file, causing it to be
processed before the internal handling of udev's `uacccess`.
@bigbigmdm
Copy link
Owner

"Collective Intelligence" concluded that the file name would be better to make 71-CH341.rules and remove the obsolete definitions MODE="0660", GROUP="plugdev".

@wucke13
Copy link
Author

wucke13 commented May 27, 2024

@bigbigmdm No problem, I can adjust accordingly. Is there a changelog somewhere? This will become a breaking change, when we remove plugdev. Hence it should be noted in the changelog/release notes.

@bigbigmdm
Copy link
Owner

I have changed these files. You can check the changelog in the latest release. If you can check the German translation - I would be glad. (Please see here and here).

@Fantu
Copy link
Collaborator

Fantu commented May 27, 2024

New version was already released without update the changelog, anyway at least release notes is complete.
I try to suggest again to have more extended and complete changelog (#19 (comment)) instead keep one line for version and incomplete even if is in dedicate file

@bigbigmdm
Copy link
Owner

bigbigmdm commented May 27, 2024

@Fantu, let me delete the release. I'll do gbp import-ref -u1.4.1 and ask you to make a proper debian/changelog. Do I need to somehow specify in the packaging that the old 99-CH341.rules should be deleted?

Or is there no need to delete the release?

@Fantu
Copy link
Collaborator

Fantu commented May 27, 2024

@bigbigmdm Don't delete the release, don't have important issue and now the project is followed and used by many people and distro, so is better to avoid bad things.
Changelog improvements can be done now (also improving some old version entries) and for newer version but without override the latest release/tag.

About Debian packaging:
udev rules is not in /etc so don't require maintscript to remove the old entry (like was for old .dat when was in /etc)
about d/changelog this is a relevant change that can be good to notify, next d/changelog entry can be for example something like:

* New upstream version
  - Renamed udev rule from 99-CH341.rules to 71-CH341.rules (for uaccess)
     and removed deprecated MODE=660 and GROUP+=plugdev
* Fix debian/watch

@bigbigmdm
Copy link
Owner

@Fantu , please help to write a correct debian/changelog file.

@Fantu
Copy link
Collaborator

Fantu commented May 27, 2024

I suppose should start from something like:

imsprog (1.4.1-1) unstable; urgency=medium

  * New upstream version
    - Renamed udev rule from 99-CH341.rules to 71-CH341.rules (for uaccess)
      and removed MODE=660 and GROUP+=plugdev
  * Fix debian/watch

@bigbigmdm
Copy link
Owner

bigbigmdm commented May 27, 2024

@Fantu, are previous records required:

imsprog (1.3.9-1) unstable; urgency=medium

  * New upstream version (Closes: #1070883)
  * Update debian/copyright
  * d/control: add qttools5-dev to build-deps
  * d/rules: add all hardening
  * Bump debhelper compat to 13
  * Bump Standards-Version to 4.7.0, no needed changes

 -- Mikhail Medvedev <e-ink-reader@yandex.ru>  Mon, 13 May 2024 15:09:18 +0300

imsprog (1.3.2-1) unstable; urgency=medium

  * Initial release (Closes: #1057386)

 -- Mikhail Medvedev <e-ink-reader@yandex.ru>  Mon, 26 Feb 2024 13:16:51 +0300```

@Fantu
Copy link
Collaborator

Fantu commented May 27, 2024

yes all are uploaded version (https://tracker.debian.org/pkg/imsprog/news/) so must be keeped

@bigbigmdm
Copy link
Owner

Thank you, @Fantu ! I'm finally starting to understand something. :)

@wucke13
Copy link
Author

wucke13 commented May 27, 2024

This was already fixed by 947320f, hence this PR is obsolete.

@wucke13 wucke13 closed this May 27, 2024
@bigbigmdm
Copy link
Owner

@wucke13 , Yes, thank you for your help!

@wucke13
Copy link
Author

wucke13 commented Jun 22, 2024

I have changed these files. You can check the changelog in the latest release. If you can check the German translation - I would be glad. (Please see here and here).

I did so, find my results here: #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The TAG+="uaccess" has no effect in the udev rule
3 participants