Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRN2-xx: Home rooms are created for all users with role if can_create_rooms is enabled #1694

Merged
merged 3 commits into from
May 28, 2020

Conversation

farhatahmad
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented May 28, 2020

Coverage Status

Coverage increased (+0.08%) to 91.255% when pulling 56d450c on farhatahmad:create-home-rooms into 5e4fe3b on bigbluebutton:master.

@farhatahmad farhatahmad merged commit fe363e7 into bigbluebutton:master May 28, 2020
@Schmidie64
Copy link

I'm sorry that I have to bother you again :) But despite your fix, the bug is still not fixed for me. I get the following error message in the log / production.log:

INFO: [374ea2a3-1a4d-4871-bed4-01664aed8632] method=POST path=/b/u/login format=html controller=SessionsController action=create status=500 error=ActionController::ActionControllerError: Cannot redirect to nil! duration=302.01 view=0.00 db=1.75 host=greenlight FATAL: [374ea2a3-1a4d-4871-bed4-01664aed8632] FATAL: [374ea2a3-1a4d-4871-bed4-01664aed8632] ActionController::ActionControllerError (Cannot redirect to nil!): FATAL: [374ea2a3-1a4d-4871-bed4-01664aed8632] FATAL: [374ea2a3-1a4d-4871-bed4-01664aed8632] app/controllers/concerns/authenticator.rb:58:in check_email_verified [374ea2a3-1a4d-4871-bed4-01664aed8632] app/controllers/concerns/authenticator.rb:32:in login [374ea2a3-1a4d-4871-bed4-01664aed8632] app/controllers/sessions_controller.rb:94:in create INFO: [374ea2a3-1a4d-4871-bed4-01664aed8632] method=POST path=/b/500 format=html controller=ErrorsController action=internal_error status=500 duration=18.28 view=13.23 db=0.60 host=greenlight INFO: [814655e0-1c5c-4068-87ed-6cf5d74a0e18] method=GET path=/b/500 format=html controller=ErrorsController action=internal_error status=500 duration=18.17 view=12.51 db=0.61 host=greenlight

@farhatahmad
Copy link
Collaborator Author

No worries @Schmidie64. Try turning off "Can Create Rooms", save, then turn it back on and save

@Schmidie64
Copy link

Oh men. Thank you good to know. Thought that is done automatically when I assign a new role to the user

pull bot pushed a commit to styliteag/greenlight that referenced this pull request May 30, 2020
@farhatahmad farhatahmad deleted the create-home-rooms branch June 15, 2020 18:43
MBcom pushed a commit to MBcom/enforce-authentication-greenlight that referenced this pull request Apr 10, 2021
…matik

* commit '8355c59b00750e82822f0e9f67537a832baa15a3':
  Upgrade LDAP gem version (bigbluebutton#1700)
  Fixed room remove task (bigbluebutton#1695)
  Home rooms are created for all users with role if can_create_rooms is enabled (bigbluebutton#1694)
  Translate '/config/locales/en.yml' in 'zh_CN' (bigbluebutton#1683)
  Fixed user create rake task (bigbluebutton#1690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants