Add SMTP check for reset password link #5303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
farhatahmad
reviewed
Jul 5, 2023
|
|
||
| export default function ForgetPassword() { | ||
| const { t } = useTranslation(); | ||
| const { data: env, isLoading } = useEnv(); | ||
|
|
||
| if (isLoading) return null; |
There was a problem hiding this comment.
Haven't we stopped doing this due to weird loading issues?
There was a problem hiding this comment.
It is glitchy without it - the card will flash briefly before redirection.
I don't remember the isLoading being a problem.
It is used elsewhere.
The proper solution would be to make a placeholder but really this is an edgecase.
It is only if a user tries to access /forget_password directly which should pretty much never happen.
pachidj87
pushed a commit
to ZumbTech/Auditorium
that referenced
this pull request
Jul 19, 2023
* Add SMTP check for reset password link * Add redirect to /forget_password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #5059
The "Reset Password link on the sign in page should be removed if the SMTP server is not set up.
The
/forget_passwordcomponent should redirect to homepage if the SMTP server is not set up.