Fix issue with recording resync deleting recordings #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Ithanil
reviewed
Oct 12, 2023
| @@ -68,7 +68,7 @@ def get_recording_length(recording:) | |||
| length = 0 | |||
| if recording[:playback][:format].is_a?(Array) | |||
| recording[:playback][:format].each do |formats| | |||
| length = formats[:length] if formats[:type] == 'presentation' | |||
| length = formats[:length] if formats[:type] == 'presentation' || formats[:type] == 'video' | |||
There was a problem hiding this comment.
Is it necessary to use specific formats here? Besides presentation or video it could also be podcast, notes, screenshare or potentially a custom format.
There was a problem hiding this comment.
Actually, nevermind. The other formats probably don't provide a length value? I'm also wondering what is it even used for?
simoncolincap
added a commit
to dBildungsplattform/greenlight
that referenced
this pull request
Oct 26, 2023
* st * Improved room sharing * Update SECURITY.md (bigbluebutton#5406) * Translate app/assets/locales/en.json in hu (bigbluebutton#5427) 100% translated source file: 'app/assets/locales/en.json' on 'hu'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Translate config/locales/en.yml in hu (bigbluebutton#5426) 100% translated source file: 'config/locales/en.yml' on 'hu'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com> * Translate config/locales/en.yml in fa_IR (bigbluebutton#5422) 100% translated source file: 'config/locales/en.yml' on 'fa_IR'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Updates for file app/assets/locales/en.json in gl on branch master (bigbluebutton#5384) * Translate app/assets/locales/en.json in gl 100% translated source file: 'app/assets/locales/en.json' on 'gl'. * Translate app/assets/locales/en.json in gl 100% translated source file: 'app/assets/locales/en.json' on 'gl'. * Translate app/assets/locales/en.json in gl 100% translated source file: 'app/assets/locales/en.json' on 'gl'. --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Updates for file app/assets/locales/en.json in tr on branch master (bigbluebutton#5382) * Translate app/assets/locales/en.json in tr 100% translated source file: 'app/assets/locales/en.json' on 'tr'. * Translate app/assets/locales/en.json in tr 100% translated source file: 'app/assets/locales/en.json' on 'tr'. * Translate app/assets/locales/en.json in tr 100% translated source file: 'app/assets/locales/en.json' on 'tr'. * Translate app/assets/locales/en.json in tr 100% translated source file: 'app/assets/locales/en.json' on 'tr'. --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Updates for file config/locales/en.yml in tr on branch master (bigbluebutton#5381) * Translate config/locales/en.yml in tr 100% translated source file: 'config/locales/en.yml' on 'tr'. * Translate config/locales/en.yml in tr 100% translated source file: 'config/locales/en.yml' on 'tr'. --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Translate config/locales/en.yml in de (bigbluebutton#5378) 100% translated source file: 'config/locales/en.yml' on 'de'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Translate app/assets/locales/en.json in de (bigbluebutton#5377) 100% translated source file: 'app/assets/locales/en.json' on 'de'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Updates for file app/assets/locales/en.json in el on branch master (bigbluebutton#5375) * Translate app/assets/locales/en.json in el 100% translated source file: 'app/assets/locales/en.json' on 'el'. * Translate app/assets/locales/en.json in el 100% translated source file: 'app/assets/locales/en.json' on 'el'. * Translate app/assets/locales/en.json in el 100% translated source file: 'app/assets/locales/en.json' on 'el'. * Translate app/assets/locales/en.json in el 100% translated source file: 'app/assets/locales/en.json' on 'el'. * Translate app/assets/locales/en.json in el 100% translated source file: 'app/assets/locales/en.json' on 'el'. * Translate app/assets/locales/en.json in el 100% translated source file: 'app/assets/locales/en.json' on 'el'. --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Translate config/locales/en.yml in zh_TW (bigbluebutton#5373) 100% translated source file: 'config/locales/en.yml' on 'zh_TW'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Translate config/locales/en.yml in zh_TW (bigbluebutton#5372) 100% translated source file: 'config/locales/en.yml' on 'zh_TW'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Updates for file config/locales/en.yml in gl on branch master (bigbluebutton#5370) * Translate config/locales/en.yml in gl 100% translated source file: 'config/locales/en.yml' on 'gl'. * Translate config/locales/en.yml in gl 100% translated source file: 'config/locales/en.yml' on 'gl'. --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Translate app/assets/locales/en.json in fr (bigbluebutton#5368) 100% translated source file: 'app/assets/locales/en.json' on 'fr'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Updates for file config/locales/en.yml in fr on branch master (bigbluebutton#5367) * Translate config/locales/en.yml in fr 100% translated source file: 'config/locales/en.yml' on 'fr'. * Translate config/locales/en.yml in fr 100% translated source file: 'config/locales/en.yml' on 'fr'. --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * Bump puma from 5.6.5 to 5.6.7 (bigbluebutton#5387) Bumps [puma](https://github.com/puma/puma) from 5.6.5 to 5.6.7. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v5.6.5...v5.6.7) --- updated-dependencies: - dependency-name: puma dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com> * [Snyk] Fix for 2 vulnerabilities (bigbluebutton#5391) * fix: Gemfile & Gemfile.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-5851458 - https://snyk.io/vuln/SNYK-RUBY-RAILTIES-5851410 * Update Gemfile.lock --------- Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com> * Fix CI (bigbluebutton#5432) * Fix Greenlight CI * Rubocop fixes * fix: Gemfile & Gemfile.lock to reduce vulnerabilities (bigbluebutton#5399) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-5851458 - https://snyk.io/vuln/SNYK-RUBY-RACK-1061917 - https://snyk.io/vuln/SNYK-RUBY-RAILTIES-5851410 Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com> * fix: Gemfile & Gemfile.lock to reduce vulnerabilities (bigbluebutton#5408) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-5851458 - https://snyk.io/vuln/SNYK-RUBY-RACK-1061917 - https://snyk.io/vuln/SNYK-RUBY-RAILTIES-5851410 Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com> * fix: config.env not found (bigbluebutton#5410) `bin/start` should most likely read `bin/config.env` instead of `config.env` as the working directory is probably *not* `./bin` but `.` * Migrate room access codes (bigbluebutton#5434) * Upgrade cssbundling version (bigbluebutton#5438) * Fix issue with recording resync deleting recordings (bigbluebutton#5449) * Fix issue with room link throwing error when authenticated (bigbluebutton#5450) * [Snyk] Security upgrade lograge from 0.13.0 to 0.14.0 (bigbluebutton#5447) * fix: Gemfile & Gemfile.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-RACK-1061917 * Update Gemfile.lock --------- Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com> * fix: Gemfile to reduce vulnerabilities (bigbluebutton#5443) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-ACTIONCABLE-20338 Co-authored-by: snyk-bot <snyk-bot@snyk.io> * [Snyk] Fix for 1 vulnerabilities (bigbluebutton#5442) * fix: Gemfile & Gemfile.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-RACK-1061917 * Update Gemfile.lock --------- Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com> * fix: Gemfile to reduce vulnerabilities (bigbluebutton#5441) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-RACK-1061917 Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com> * Fix upgrade (bigbluebutton#5451) * Fixed issues with default locale (bigbluebutton#5452) * Add additional fail safe for action cable (bigbluebutton#5453) * Added clear inteval when action cable works (bigbluebutton#5454) * update changed recording URLs of already present formats instead of creating new format entries (bigbluebutton#5460) * add hover tooltips for the copy-URL&delete buttons in room recording lists (bigbluebutton#5458) * Increase file upload size to 30mb (bigbluebutton#5461) * Fix bug with default locale (bigbluebutton#5462) * Fixed issue in install script with secret generation (bigbluebutton#5466) * add whitespace after uses of shared_by string, remove the whitespace from english locale (bigbluebutton#5468) * Fix for superadmins when changing pages (bigbluebutton#5470) * Fix for superadmins when changing pages * eslint * Fixed mixup with the ICS branch. * Fixed missing import * DBP-245 Recreate app/assets/builds/.keep --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Your Name <you@example.com> Co-authored-by: SebastianAppDev <128802341+SebastianAppDev@users.noreply.github.com> Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Jesus Federico <jesus@123it.ca> Co-authored-by: Marc Kohaupt <debuglevel@gmail.com> Co-authored-by: Jan Kessler <Ithanil@users.noreply.github.com> Co-authored-by: Nadler, Sebastian <sebastian.nadler@secunet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.