GRN2-176: Create a role editor that allows admins to specify what permissions each role has #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix super admins
farhatahmad
reviewed
Jul 30, 2019
farhatahmad
reviewed
Jul 30, 2019
shawn-higgins1
force-pushed
the
add-roles-editor
branch
from
6bf4bc5 to
c141a6f
Compare
jfederico
approved these changes
Jul 31, 2019
balert
pushed a commit
to tubraunschweig/greenlight
that referenced
this pull request
Mar 31, 2020
…missions each role has (bigbluebutton#709) * Add roles editor * Add colour selection ability to roles * Add ability to assign roles to users in the UI * Remove rolify and replace it with our own custom roles implemenation * - Fix all existing roles functionality - Fix super admins * Fix bugs with new customers not have default roles * Add can't create room setting * Code improvements * Fix migration * Add tests for new methods * Translate reserved role names * Pull roles from saml/ldap * Fix rspec * Fix scrutinizer issues * Fix email promoted/demoted tests * Apply comments * Redirect directly to the main room * Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've create this large PR as a preliminary pass at a roles editor. However, there are some other options for roles management:
It would be great to get some feedback on what option you guys think is the best way forward.