-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add localization overview & guide #1332
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
With #1333 we need to update the folder location of some of the objects we set for localization. |
@jorgemoya It looks like PR 1333 is merged. Can my PR be approved? |
I think I confused things @bc-andreadao. What I meant to say is that with the latest changes from #1333, the |
@jorgemoya Ah I see, thanks for clarifying. If you could help me make the changes to this PR that would work |
@bc-andreadao Yeah I will! |
8930bd2
to
87966c6
Compare
87966c6
to
36253bc
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-5y3jb7zpt-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
This PR adds the localization overview & guide back into the docs for DEVDOCS-6062.
PR 1298, where I originally added the localization overview & guide, was reverted in PR 1306. The reason was that subdirectories aren't supported for the catalyst.dev repository (https://bigcommerce.slack.com/archives/C0740QWEF9R/p1724446019589669), so the docs would not appear in the navigation bar.
This PR adds the overview & guide back into the docs, but places them under the /docs directory (no subdirectories).
See PR 21 for new navigation bar changes. Must merge this PR before PR 21.
Testing
N / A