Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename leftover references to NEXT_PUBLIC_DEFAULT_REVALIDATE_TARGET #1366

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

matthewvolk
Copy link
Contributor

Note

Stacks on #1365

What/Why?

Renames a few more references to NEXT_PUBLIC_DEFAULT_REVLIDATE_TARGET env var, missed in #1317

Testing

Search all repository files for "NEXT_PUBLIC_DEFAULT_REVALIDATE_TARGET"

@matthewvolk matthewvolk requested a review from a team as a code owner September 13, 2024 14:25
Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 7c9077e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/create-catalyst Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 2:55pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Sep 13, 2024 2:55pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 2:55pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 2:55pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 2:55pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 2:55pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 2:55pm

@matthewvolk matthewvolk added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 6d7c508 Sep 13, 2024
13 checks passed
@matthewvolk matthewvolk deleted the fix/revalidate-target-env-var branch September 13, 2024 15:01
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-bqllty8po-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 83
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 88
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants