Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve styling of html product descriptions #1972

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

becomevocal
Copy link
Contributor

What/Why?

Updates the product description styles to space out elements and support the same header styling as the web page route.

This helps the content blend into the aesthetic better. The content is smashed together now, which is strange to have as a default!

Note: I could totally see this being inside vibe components themselves. If that makes more sense, I'll close this PR and make the changes there.

Testing

Before:
Screenshot 2025-02-11 at 11 03 04 AM

After:
Screenshot 2025-02-11 at 11 03 34 AM

@becomevocal becomevocal requested a review from a team as a code owner February 11, 2025 17:24
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:24pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Feb 11, 2025 5:24pm
catalyst-au ⬜️ Ignored (Inspect) Feb 11, 2025 5:24pm
catalyst-soul ⬜️ Ignored (Inspect) Feb 11, 2025 5:24pm
catalyst-uk ⬜️ Ignored (Inspect) Feb 11, 2025 5:24pm

Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: eb83cd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@migueloller migueloller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@becomevocal, this looks a lot better! I do think this should be a change that's applied in VIBES so that the prose class applies these styles consistently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants