Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Implement & Test DINA #51

Open
wants to merge 4 commits into
base: 2.0
Choose a base branch
from
Open

[Dev] Implement & Test DINA #51

wants to merge 4 commits into from

Conversation

CSLiJT
Copy link

@CSLiJT CSLiJT commented Jan 22, 2024

Thanks for sending a pull request!
Please make sure you click the link above to view the contribution guidelines,
then fill out the blanks below.

Description

(Brief description on what this PR is about)

What does this implement/fix? Explain your changes.

...

Pull request type

  • [DATASET] Add a new dataset
  • [BUGFIX] Bugfix
  • [FEATURE] New feature (non-breaking change which adds functionality)
  • [BREAKING] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [STYLE] Code style update (formatting, renaming)
  • [REFACTOR] Refactoring (no functional changes, no api changes)
  • [BUILD] Build related changes
  • [DOC] Documentation content changes
  • [Sync] Synchronization with a repository
  • [OTHER] Other (please describe):

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

or

  • Fix1, tests
  • Fix2, tests

Does this close any currently open issues?

...

Any relevant logs, error output, etc?

...

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [FEATURE], [BREAKING], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage and al tests passing
  • Code is well-documented (extended the README / documentation, if necessary)
  • If this PR is your first one, add your name and github account to AUTHORS.md

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17a1aa0) 88.72% compared to head (a2e5aab) 90.18%.
Report is 12 commits behind head on 2.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0      #51      +/-   ##
==========================================
+ Coverage   88.72%   90.18%   +1.46%     
==========================================
  Files          13       15       +2     
  Lines         745      856     +111     
==========================================
+ Hits          661      772     +111     
  Misses         84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


# def load(self, filepath):
# self.dina_net.load_state_dict(torch.load(filepath))
# logging.info("load parameters from %s" % filepath)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete these annotations if they are not necessary.

@LegionKing
Copy link
Collaborator

  1. Examples and docs are missed.
  2. DINA trained with EM is also required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants