-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replacing uses of deprecated class SAMFileReader #1235
replacing uses of deprecated class SAMFileReader #1235
Conversation
this is necessary to be compatible with htsjdk 2.7.0+
Can one of the admins verify this patch? |
Awesome, thanks @lbergelson! I will take a look at this later today. |
Jenkins, test this please. |
Test PASSed. |
This looks good to me, but there's a couple of small style nits (mostly import ordering stuff, we're picky). I'll clean those up. Thanks for making the upgrade pass @lbergelson! |
Ah, sorry about the import stuff. My IDE did some automatic import shuffling I think. |
Oh, no worries! It's a pretty small bit of cleanup. |
I can do a quick fix up of them if you'd like, or if it's easier I'll leave it to you. |
No sweat; I've got it 75% done already. |
I've cleaned up the little import nits in #1236. Thank you @lbergelson for the patches! |
Thank you! |
Replacing all references to
SAMFileReader
, this is a long deprecated htsjdk class that's been replaced bySamReader
.