[ADAM-1242] Clean up dead code in org.bdgenomics.adam.util. #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves bigdatagenomics#1242. Removed: * org.bdgenomics.adam.util.ImplicitJavaConversions * org.bdgenomics.adam.util.IntervalListReader * org.bdgenomics.adam.util.MapTools * org.bdgenomics.adam.util.RegExp * org.bdgenomics.adam.util.Util
|
Test PASSed. |
|
Test PASSed. |
heuermh
requested changes
Nov 7, 2016
| case class ReferenceContigMap(contigMap: Map[String, Seq[NucleotideContigFragment]]) extends ReferenceFile { | ||
|
|
||
| // create sequence dictionary | ||
| /** | ||
| * The sequence dictionary corresponding to the contigs in this two bit file. |
|
Looks great other than one doc fix |
…nup: * Moved `NormalizationUtils` to `org.bdgenomics.adam.algorithms.consensus`, and made it package private to `consensus`. * Moved `MdTag` to `org.bdgenomics.adam.models`. * Moved `QualityScore` to `org.bdgenomics.adam.models` and made it package private to `consensus`.
fnothaft
force-pushed
the
issues/1242-cleanup-util
branch
from
f148b07
to
bdf626c
Compare
|
Fixed the documentation issue and pushed. |
|
Test PASSed. |
heuermh
approved these changes
Nov 7, 2016
|
Thanks, @fnothaft! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1242. Removed: