Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up mpileup command #169

Merged
merged 1 commit into from
Mar 17, 2014

Conversation

arahuja
Copy link
Contributor

@arahuja arahuja commented Mar 12, 2014

This just cleans up the mpileup command to separate out the context handling

A few questions:

  1. Does this command still have utility? Also is its only utility in local spark?
  2. If so, should we combine PileupTraversable and the other pileup processing since both seem to implement the same read to pileup parsing

@massie
Copy link
Member

massie commented Mar 12, 2014

The original idea around this command was to allow ADAM to rapidly pre-process aligned reads and them pipe them to mpileup-based variant callers. I'm not sure who, if anyone, is using this functionality. There was interest from UCSC months ago but I haven't been tracking that work since.

The PileupTraversable does "on the fly" pileup creation assuming sorted input which is a bit different than the other pileup approaches.

@AmplabJenkins
Copy link

One or more automated tests failed
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/211/

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/212/

@nealsid nealsid deleted the mpileup-update branch March 13, 2014 18:52
@arahuja arahuja restored the mpileup-update branch March 13, 2014 18:53
@fnothaft
Copy link
Member

@arahuja I believe this is ready to be merged but needs to be squashed first. Can you squash this?

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/225/

fnothaft added a commit that referenced this pull request Mar 17, 2014
@fnothaft fnothaft merged commit 141cbd2 into bigdatagenomics:master Mar 17, 2014
@fnothaft
Copy link
Member

Merged! Thanks @arahuja!

@arahuja arahuja deleted the mpileup-update branch March 17, 2014 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants