-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build up reference information during cigar processing #233
Conversation
@@ -180,6 +179,9 @@ case class ReferenceRegion(referenceName: String, start: Long, end: Long) extend | |||
def overlaps(other: ReferenceRegion): Boolean = | |||
referenceName == other.referenceName && end > other.start && start < other.end | |||
|
|||
def overlaps(other: ReferencePosition): Boolean = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this different from the contains(other: ReferencePosition) method above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not - didn't see that one, will update, thanks!
+1, looks good!
I've been speaking with the UCSC folks about this. I'm hoping to have a design document/writeup for this approach by the end of the week. |
All automated tests passed. |
All automated tests passed. |
Sorry to be a commit history nag but can you move some of the PR description over to the git commit message? |
All automated tests passed. |
…processing; remove reference location in favor of reference position
Rebased after #230 merged in. |
All automated tests passed. |
Build up reference information during cigar processing
Thanks, Arun! |
This PR is to track more reference information during the cigar processing.
Currently, RichADAMRecord parses the Cigar string to extract the reference position (as a Long).
This:
Also, this removes ReferenceLocation in favor of ReferencePosition as they had duplicate functionality
Noted issues: