Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding reads to rods transformation. #36

Merged
merged 1 commit into from
Jan 21, 2014
Merged

Adding reads to rods transformation. #36

merged 1 commit into from
Jan 21, 2014

Conversation

fnothaft
Copy link
Member

Addresses performance issue with reads->pileups->rods transform, while providing equivalent semantics.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM/124/

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM/127/

massie
massie reviewed Dec 18, 2013
View reviewed changes
adam-commands/src/main/scala/edu/berkeley/cs/amplab/adam/rdd/AdamRDDFunctions.scala
}
}

println("Putting reads in buckets.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to leave in the println debug statements?

@massie
Copy link
Member

massie commented Dec 20, 2013

Let me know when the debug statements are removed and I'll commit this. You should also feel free to commit this change yourself once the debug statements are removed.

Good stuff.

@AmplabJenkins
Copy link

Build triggered.

@massie
Copy link
Member

massie commented Jan 13, 2014

Jenkins, test this please.

@massie
Copy link
Member

massie commented Jan 13, 2014

@fnothaft Is this pull request still something you want to merge in? If so, I'm happy to review it and get it committed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/24/

@massie
Copy link
Member

massie commented Jan 16, 2014

This will need to be rebased onto master since the adam-commands module no longer exists.

@fnothaft
Copy link
Member Author

Matt, this is rebased to master now and should be good to merge.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/44/

massie added a commit that referenced this pull request Jan 21, 2014
@massie
Merge pull request #36 from bigdatagenomics/reads-to-rods
aa0a078 
Adding reads to rods transformation.
@massie massie merged commit aa0a078 into master Jan 21, 2014
@massie
Copy link
Member

massie commented Jan 21, 2014

Thanks, Frank!

@fnothaft fnothaft deleted the reads-to-rods branch January 27, 2014 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fnothaft @AmplabJenkins @massie