Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stores original position and original cigar during realignment. #417

Merged
merged 1 commit into from
Nov 2, 2014

Conversation

niranjan93
Copy link
Member

Stores original position and original cigar during realignment.
Addresses issue #348 in the adam project.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@fnothaft
Copy link
Member

Jenkins, add to whitelist.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/296/

Build result: FAILURE

GitHub pull request #417 of commit ae38a31 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 4f3e5b7 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 4f3e5b7 > git rev-list fa32bbf # timeout=10First time build. Skipping changelog.Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

@fnothaft
Copy link
Member

Jenkins, retest this please.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/304/

Build result: FAILURE

GitHub pull request #417 of commit ae38a31 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 7406d00 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 7406d00 > git rev-list db0f900 # timeout=10Triggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILURE
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/307/

Build result: FAILURE

GitHub pull request #417 of commit 77ea367 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 01b4a29 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 01b4a29 > git rev-list db0f900 # timeout=10Triggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 2.2.0,centosADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILURE
Test FAILed.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@fnothaft
Copy link
Member

Jenkins, add to whitelist.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/309/

Build result: FAILURE

GitHub pull request #417 of commit 77ea367.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse 77ea367^{commit} # timeout=10Checking out Revision 77ea367 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 77ea367 > git rev-list db0f900 # timeout=10Triggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosTriggering ADAM-prb » 2.2.0,centosADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILUREADAM-prb » 2.2.0,centos completed with result FAILURE
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/328/

Build result: FAILURE

GitHub pull request #417 of commit f3ef0c8 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 2592f2c (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 2592f2c > git rev-list a9008c4 # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/331/

Build result: FAILURE

GitHub pull request #417 of commit f0bc0f0 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 7dc5bba (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 7dc5bba > git rev-list c12c117 # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/333/

Build result: FAILURE

GitHub pull request #417 of commit 4186c74 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 905bb58d27ebdf9a7b4cebedee15265f3ddbfbba (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 905bb58d27ebdf9a7b4cebedee15265f3ddbfbba > git rev-list 7dc5bba # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result SUCCESSADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/334/
Test PASSed.

@@ -135,7 +135,7 @@
<configuration>
<rules>
<requireMavenVersion>
<version>[3.1.1,)</version>
<version>[3.0.4,)</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional? Some users have reported issues building with Maven 3.0.x.

@massie
Copy link
Member

massie commented Nov 1, 2014

Aside from relaxing the Maven version requirement, this code looks ready to merge to me.

@niranjan93
Copy link
Member Author

Should I change it to 3.1.1? What is the preferred Maven version?

@massie
Copy link
Member

massie commented Nov 1, 2014

Yes. 3.1.1 please.

-Matt
(Sent from phone)
On Nov 1, 2014 1:39 PM, "niranjan93" notifications@github.com wrote:

Should I change it to 3.1.1? What is the preferred Maven version?


Reply to this email directly or view it on GitHub
#417 (comment).

@niranjan93
Copy link
Member Author

Unfortunately, changing the version from 3.0.4 to 3.1.1 causes the build to fail:

niranjan93@crick:~/adam$ mvn test
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.bdgenomics.adam:adam-core:jar:0.14.1-SNAPSHOT
[WARNING] 'dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 364, column 25
[WARNING] 'dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '
' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 368, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 364, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '
' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 368, column 25
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.bdgenomics.adam:adam-apis:jar:0.14.1-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 364, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '
' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 368, column 25
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.bdgenomics.adam:adam-cli:jar:0.14.1-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 364, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '
' does not match a valid id pattern. @ org.bdgenomics.adam:adam-parent:0.14.1-SNAPSHOT, /home/niranjan93/adam/pom.xml, line 368, column 25
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.bdgenomics.adam:adam-parent:pom:0.14.1-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '' does not match a valid id pattern. @ line 364, column 25
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '
' does not match a valid id pattern. @ line 368, column 25
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] ADAM
[INFO] ADAM: Core
[INFO] ADAM: APIs for Java
[INFO] ADAM: CLI
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building ADAM 0.14.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-versions) @ adam-parent ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message:
ADAM requires Maven 3.1.1 or greater
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] ADAM .............................................. FAILURE [0.631s]
[INFO] ADAM: Core ........................................ SKIPPED
[INFO] ADAM: APIs for Java ............................... SKIPPED
[INFO] ADAM: CLI ......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.981s
[INFO] Finished at: Sat Nov 01 14:25:47 PDT 2014
[INFO] Final Memory: 21M/1963M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.0:enforce (enforce-versions) on project adam-parent: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/342/
Test PASSed.

@massie
Copy link
Member

massie commented Nov 1, 2014

I believe that someone fixed this. I just checked and the Maven version for
ADAM and ADAM pull request builder are 3.1.1. All your tests passed! Looks
good.

-Matt

On Sat, Nov 1, 2014 at 2:39 PM, UCB AMPLab notifications@github.com wrote:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/342/
Test PASSed.


Reply to this email directly or view it on GitHub
#417 (comment).

@@ -305,7 +305,7 @@
<dependency>
<groupId>org.bdgenomics.bdg-formats</groupId>
<artifactId>bdg-formats</artifactId>
<version>0.3.1</version>
<version>0.3.2</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the bump to bdg-formats intentional?

@niranjan93
Copy link
Member Author

I'm not actually sure why it's 0.3.2. Should I change it to 0.3.1?

@massie
Copy link
Member

massie commented Nov 1, 2014

Yes, please. Once you change it to 0.3.1, I'll be happy to merge this code.
Thanks for the contribution!

-Matt

On Sat, Nov 1, 2014 at 3:31 PM, niranjan93 notifications@github.com wrote:

I'm not actually sure why it's 0.3.2. Should I change it to 0.3.1?


Reply to this email directly or view it on GitHub
#417 (comment).

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/343/

Build result: FAILURE

GitHub pull request #417 of commit ccc640b automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision 5a3a8ea90533d65453d705fda97b9408ec65e730 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 5a3a8ea90533d65453d705fda97b9408ec65e730 > git rev-list c648a6f2090c2b8df001dfef497bea6c70f02df4 # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

@fnothaft
Copy link
Member

fnothaft commented Nov 1, 2014

@massie the bdg-formats dependency needs to be 0.3.2; we added the originalCigar and originalPosition fields in 0.3.2.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/344/

Build result: FAILURE

GitHub pull request #417 of commit fef9713 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-slave-01 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/417/merge^{commit} # timeout=10Checking out Revision a7a2569f68f2981425bb14e2fffc1bdbd8024b8c (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f a7a2569f68f2981425bb14e2fffc1bdbd8024b8c > git rev-list 5a3a8ea90533d65453d705fda97b9408ec65e730 # timeout=10Triggering ADAM-prb » 2.2.0,centosTriggering ADAM-prb » 1.0.4,centosTriggering ADAM-prb » 2.3.0,centosADAM-prb » 2.2.0,centos completed with result FAILUREADAM-prb » 1.0.4,centos completed with result FAILUREADAM-prb » 2.3.0,centos completed with result FAILURE
Test FAILed.

@niranjan93
Copy link
Member Author

I changed 0.3.1 back to 0.3.2, but the build still fails. I made sure that I didn't change anything else. I also did another rebase before pushing, but Git notified me that everything is up to date.

niranjan93@crick:/adam$ git fetch upstream
niranjan93@crick:
/adam$ git status

On branch NK_schema_tags

nothing to commit (working directory clean)
niranjan93@crick:/adam$ git rebase upstream/master
Current branch NK_schema_tags is up to date.
niranjan93@crick:
/adam$

@niranjan93
Copy link
Member Author

I have no idea why the font became so big. I had just pasted the command line output from crick. Sorry.

@massie
Copy link
Member

massie commented Nov 2, 2014

Jenkins, retest this please.

@massie
Copy link
Member

massie commented Nov 2, 2014

@niranjan93

There is no need to be sorry. Hopefully the tests will pass now.

@fnothaft
Copy link
Member

fnothaft commented Nov 2, 2014

Big fonts are back in vogue; it's like hair in the 80's. ;)

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/345/
Test PASSed.

massie added a commit that referenced this pull request Nov 2, 2014
Stores original position and original cigar during realignment.
@massie massie merged commit c4e8e23 into bigdatagenomics:master Nov 2, 2014
@niranjan93
Copy link
Member Author

I see it passes now. Thanks Matt! Thanks Frank!

@massie
Copy link
Member

massie commented Nov 2, 2014

Thanks, @niranjan93 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants