make adamLoad public #688
Merged
make adamLoad public #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -126,7 +126,7 @@ class ADAMContext(val sc: SparkContext) extends Serializable with Logging { | |||
| * @tparam T The type of records to return | |||
| * @return An RDD with records of the specified type | |||
| */ | |||
| private[rdd] def adamLoad[T](filePath: String, predicate: Option[FilterPredicate] = None, projection: Option[Schema] = None)(implicit ev1: T => SpecificRecord, ev2: Manifest[T]): RDD[T] = { | |||
| def adamLoad[T](filePath: String, predicate: Option[FilterPredicate] = None, projection: Option[Schema] = None)(implicit ev1: T => SpecificRecord, ev2: Manifest[T]): RDD[T] = { | |||
There was a problem hiding this comment.
Howabouts we rename this function from adamLoad to loadParquet?
|
Looks good! I think we made it package private under the assumption that you'd use |
|
Sorry, accidentally closed this! |
|
Sorry, accidentally closed this! |
|
@fnothaft any idea what's causing these build failures? The last two failed builds here both had errors like: This last time it was just scala 2.10 x hadoop 1.0.4, whereas previously it was all 2.10 builds |
fixes bigdatagenomics#687 - remove out-of-date @param scaladocs
|
rebased and squashed |
|
Merged! Thanks @ryan-williams! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #687