Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better transform error when file doesn't exist #805

Merged
merged 1 commit into from
Aug 24, 2015

Conversation

ryan-williams
Copy link
Member

fixes #804

Some((sd, rg))
} catch {
case e: Throwable => {
log.error(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bit is also in #803, should all come out in the merge-wash

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/873/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Aug 24, 2015

LGTM, should I merge using the Github button or might that cause trouble?

@ryan-williams
Copy link
Member Author

Last word from @fnothaft I heard was that we can still web-merge for now; his alternate scripts etc. are not fully ready.

@heuermh
Copy link
Member

heuermh commented Aug 24, 2015

After merging #802 and #803 via the Github merge button this one has a merge conflict. I'll let someone with stronger git-fu chime in on how best to proceed.

@ryan-williams
Copy link
Member Author

I'll resolve it and push to this branch again, 1m

On Mon, Aug 24, 2015 at 3:59 PM Michael L Heuer notifications@github.com
wrote:

After merging #802 #802 and
#803 #803 via the Github
merge button this one has a merge conflict. I'll let someone with stronger
git-fu chime in on how best to proceed.


Reply to this email directly or view it on GitHub
#805 (comment).

@ryan-williams
Copy link
Member Author

rebased; let's see what jenkins has to say

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/885/
Test PASSed.

heuermh added a commit that referenced this pull request Aug 24, 2015
Better transform error when file doesn't exist
@heuermh heuermh merged commit 9bf6942 into bigdatagenomics:master Aug 24, 2015
@heuermh
Copy link
Member

heuermh commented Aug 24, 2015

Thanks @ryan-williams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhelpful stack-trace when bam-loading a nonexistent path
3 participants