Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adamGetReferenceString reduces pairs correctly, fixes #967 #970

Merged
merged 1 commit into from
Mar 22, 2016

Conversation

erictu
Copy link
Member

@erictu erictu commented Mar 17, 2016

fixes #967

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1107/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Mar 21, 2016

Thank you, @erictu. Could you add a unit test demonstrating the issue?

@erictu
Copy link
Member Author

erictu commented Mar 21, 2016

Done. Just to note, because the bug is nondeterministic (based on how Spark optimizes its reduce function), the unit test without the fixes doesn't always throw an error. With the new fixes, the test passes all the time.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1108/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Mar 22, 2016

Thanks, I understand now. LGTM

@heuermh heuermh merged commit 3f21d83 into bigdatagenomics:master Mar 22, 2016
@heuermh
Copy link
Member

heuermh commented Mar 22, 2016

Thank you, @erictu, merged as 3f21d83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adamGetReferenceString doesn't reduce pairs correctly
3 participants