This repository has been archived by the owner on Aug 29, 2022. It is now read-only.
Declutter Future protocol #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwaldowski
force-pushed
the
zwaldowski/declutter-future-protocol
branch
2 times, most recently
from
2657c1b
to
8ba1b15
Compare
zwaldowski
force-pushed
the
zwaldowski/declutter-future-protocol
branch
from
8ba1b15
to
bcfb7f1
Compare
zwaldowski
force-pushed
the
zwaldowski/declutter-future-protocol
branch
from
bcfb7f1
to
bd8c178
Compare
zwaldowski
added a commit
that referenced
this pull request
Apr 9, 2018
…-protocol Declutter Future protocol
zwaldowski
added a commit
that referenced
this pull request
Apr 9, 2018
…-protocol Declutter Future protocol
zwaldowski
added a commit
that referenced
this pull request
Apr 9, 2018
…-protocol Declutter Future protocol
zwaldowski
added a commit
that referenced
this pull request
Apr 29, 2018
…-protocol Declutter Future protocol
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Moves default implementations out from the
FutureProtocoldefinition. Addspeek()as a requirement, removesmapandandThenas requirements.Testing
No notable changes.
TODO
Futureneed extrapeekcalls or are they already covered?API Changes
Many breaking changes to
FutureProtocol, few likely to be source-breaking.